【Challenge A/yoshifumi sawada】各プランの料金計算の実装#308
Open
zenfumi wants to merge 10 commits intoenechange:masterfrom
zenfumi:challengeA/yoshifumi_sawada
Open
【Challenge A/yoshifumi sawada】各プランの料金計算の実装#308zenfumi wants to merge 10 commits intoenechange:masterfrom zenfumi:challengeA/yoshifumi_sawada
zenfumi wants to merge 10 commits intoenechange:masterfrom
zenfumi:challengeA/yoshifumi_sawada
Conversation
|
Sider detected 1 error and 2 warnings on analyzing the commit 65b34f6. We recommend fixing them as possible by updating the dependencies, configuring the analysis tool, configuring If you have problems or questions still, feel free to ask us via chat. 💬 You can turn off this notification if you don't want to receive it from now on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
実装内容
ポイント
登場人物ごとにクラス・情報・役割を意識しました(誰が何をする)
CSV にデータ関連を切り出す
RSpec 実装(配列数と計算結果を対象とするテスト)
今後、修正を考えている点
チャレンジ課題Aに取り組ませて頂きました、澤田 善史と申します。
お忙しいところ恐縮ですが、ご確認頂けると幸いです。
リファクタリング(計算メソッドをまとめる)とプラン追加対応の為、2回目のpushをしております。
宜しくお願い致します。